Dan Kolsoi

Results 206 comments of Dan Kolsoi

If I understand correctly, I think I was already aware of this issue, and my solution was to have a `Builder` and `Builder` (or whatever better sub-type names) and only...

Thanks for looking into this. There's nothing we can do about this at compile-time, but I suppose we could panic or return an `Err` if we check every value provided...

I think `MemoryBuffer` can sometimes own its data, so we'd need a ref and owning type, I think

I thought about that too, and it's a valid option. But it feels a little dirty since there's nothing actually happening involving a `'static` lifetime

hmm, do you think you can come up with a minimal example of this?

If all possible BasicValueEnum variants support get_name, then I suppose this makes sense

We probably want https://thedan64.github.io/inkwell/llvm_sys/support/fn.LLVMAddSymbol.html but it doesn't look like we currently wrap it? Probably due to wild unsafety. I wouldn't be opposed to someone adding an `unsafe` wrapper to it

hmm not sure I totally follow. You're saying even though the API accepts a string, it isn't valid to provide one?