svelte-materialify icon indicating copy to clipboard operation
svelte-materialify copied to clipboard

feat(MaterialApp): theme scrollbars

Open Florian-Schoenherr opened this issue 3 years ago • 4 comments

squash (next time I will lint before commiting) Closes: #56

Florian-Schoenherr avatar Nov 07 '20 16:11 Florian-Schoenherr

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/3inqr3kep
✅ Preview: https://svelte-materialify-git-master.thecomputerm.vercel.app

vercel[bot] avatar Nov 07 '20 16:11 vercel[bot]

It doesn't work on vercel. And I don't know why.

Florian-Schoenherr avatar Nov 07 '20 16:11 Florian-Schoenherr

The vercel site is very buggy, I cannot scroll and the scrollbars look weird.

TheComputerM avatar Nov 07 '20 16:11 TheComputerM

Can't convert this to draft, and I guess I still need some time.

Found something: #root needs to be height: 100%. This should just be mentioned first on the MaterialApp docs. If you want, I can try some different setups (using two MaterialApps, etc). z-index on the aside is the culprit. Scrollbars don't have z-index (on chrome), so best idea for now: put margin-left: <scrollbar-width> on the side-menu. I will push a smaller scrollbar later.

Right now we have another problem: side-menu It's not updating with the new scrollbar, let me see what I can do. Update: https://github.com/cferdinandi/gumshoe/issues/114 okay, gumshoe apparently only works on the "main scrollbar". I mean, something like gumshoe which has the option to also specify the container on which scrolls happen would be nice. We could leave this open until I get the time to find an alternative or anybody has a better idea.

Florian-Schoenherr avatar Nov 07 '20 16:11 Florian-Schoenherr