svelte-materialify icon indicating copy to clipboard operation
svelte-materialify copied to clipboard

fix(Tooltip.svelte): don't destroy tip node, let svelte do it

Open dablach opened this issue 3 years ago • 1 comments

When destroying a Tooltip, the tooltip node was removed twice: once by svelte and once by the component.

This pull requests removes the removeChild call in the component and adds a test, that checks if the Tooltip component can be destroyed without an error and the tooltip node gets removed correctly.

dablach avatar Jan 24 '22 14:01 dablach

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/9ZrQCqm2zkK8cqrCRFyZaDxaRASh
✅ Preview: https://svelte-materialify-git-fork-dablach-master-thecomputerm.vercel.app

vercel[bot] avatar Jan 24 '22 14:01 vercel[bot]