MagicSpells icon indicating copy to clipboard operation
MagicSpells copied to clipboard

Add proper support for damaging with different DamageCause

Open NeumimTo opened this issue 3 years ago • 1 comments

While ms supports this, current implementation is not well made.

https://github.com/TheComputerGeek2/MagicSpells/blob/main/core/src/main/java/com/nisovin/magicspells/spells/targeted/PainSpell.java#L91-L97

it fires additional event, rather than attempting to modify edby event that would fire from craftbukkit.

Unfortunately spigot/paper api do not support damaging with custom damage cause, for now you will have to use nms. LivingEntity#hurt

Theres ongoing pr that you might either wait for to get merged (if it ever gets merged), or use it as a reference whats needed to be done https://github.com/PaperMC/Paper/pull/7423

NeumimTo avatar Jan 30 '22 17:01 NeumimTo

Waiting for the Paper Registry API to complete this.

Chronoken avatar Apr 15 '24 16:04 Chronoken