highlights icon indicating copy to clipboard operation
highlights copied to clipboard
verified publisher icon TheCodingDen

Add more user configuration

Open ThatsNoMoon opened this issue 5 years ago • 3 comments

Possible configuration options:

  • Patience duration (how long to wait for a message in the same channel before sending a notification)

ThatsNoMoon avatar Aug 28 '20 23:08 ThatsNoMoon

For the patience duration, would this be configured in minutes, seconds, or a string like "1m30s"? Should it warn and fall back to 2 minutes if the config is invalid, or should it exit early?

I also think MAX_KEYWORDS would be a good value to configure.

joshyrobot avatar Dec 29 '20 05:12 joshyrobot

I was thinking configuring the patience duration would be an end-user option that would go in the database, not in the config. That said, it wouldn't be bad to be able to configure the default patience duration either.

I would probably just do HIGHLIGHTS_PATIENCE_SECONDS and expect a number of seconds but 1m30s would be fine as well.

None of the other optional configuration options fail when they have invalid values so I don't think this one should either should it get added.

HIGHLIGHTS_MAX_KEYWORDS would be fine too.

ThatsNoMoon avatar Dec 29 '20 05:12 ThatsNoMoon

Ideas in the above comment were implemented in #36, more end-user configuration is still on the table though.

ThatsNoMoon avatar Dec 29 '20 09:12 ThatsNoMoon