Hazel icon indicating copy to clipboard operation
Hazel copied to clipboard

Implement SetupPremake.py to install 5.0.0-beta1 instead of 5.0.0-alpha16

Open manoyes opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe

This is related to the problem of having to manually retarget my projects to Visual Studio 2022. Beta1 adds native support for VS22 builds, in addition to general stability improvements.

Describe the solution you'd like

I would like the premake 5.0.0-beta1 to be installed by SetupPremake.py. If the Hazel devs wish to keep using VS 2019, that is fine as it's possible to just edit Win-Genprojects.bat locally, but installing the beta1 should generally be better for everyone due to the convenience and increased stability of a beta relative to an alpha.

Describe alternatives you've considered

None; this is a relatively small quality of life improvement.

Additional context

Premake 5.0.0-beta1 Release and Changelog

I submited a pull request for this myself as it is a small update: #546

manoyes avatar Mar 16 '22 13:03 manoyes

If you really want to upgrade to latest version of premake, I would suggest wait until the next version.

Starting from VS2019, you cannot suppress warning from external header using #pragma warning(push, 0) (see Log.h) (source). You have to set them as external header and disable external header warning from project configuration. You can try building Hazel and see warnings from fmt.

Premake just add some nice tags for external headers, externalincludedirs and externalwarnings. However, these tags haven't been included in beta1 yet (source). Which means if we upgrade to beta1 right now, we will have to upgrade again when the next version of premake is release (beta1.1?) to be able to utilize thoss tags and have a warning-free build.

3x3y3z3t avatar Jul 26 '22 00:07 3x3y3z3t