PlugMan icon indicating copy to clipboard operation
PlugMan copied to clipboard

You are calling onLoad twice

Open TauCu opened this issue 2 months ago • 1 comments

Updated to paper 1.21.10 (from 1.20.8) and plugman 3.0.2 (from 3.0.0)

It seems paper's ServerPluginProviderStorage calls onLoad and then you do:

> plugman reload Minesuiteus
[12:43:42 INFO]: [PlugManX] Successfully removed provider for plugin: Minesuiteus
[12:43:42 INFO]: [PluginRemapper] Remapping plugin 'plugins\Minesuiteus-1.0.0.jar'...
[12:43:42 INFO]: [PluginRemapper] Done remapping plugin 'plugins\Minesuiteus-1.0.0.jar' in 607ms.
[12:43:43 INFO]: [Minesuiteus] Loading server plugin Minesuiteus v1.0.0
[12:43:43 INFO]: [Minesuiteus] Minesuiteus is loading
[12:43:43 INFO]: [Minesuiteus] foo
java.lang.Throwable: null
        at Minesuiteus-1.0.0-1760319822338.jar/me.taucu.minesuiteus.Minesuiteus.onLoad(Minesuiteus.java:63) ~[Minesuiteus-1.0.0-1760319822338.jar:?]
        at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:59) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.processProvided(SingularRuntimePluginProviderStorage.java:62) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.processProvided(SingularRuntimePluginProviderStorage.java:24) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:39) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.enter(SingularRuntimePluginProviderStorage.java:57) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at io.papermc.paper.plugin.manager.RuntimePluginEntrypointHandler.enter(RuntimePluginEntrypointHandler.java:40) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.loadPlugin(PaperPluginInstanceManager.java:116) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.loadPlugin(PaperPluginManagerImpl.java:82) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:419) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.pluginmanager.BukkitPluginManager.loadAndEnablePlugin(BukkitPluginManager.java:366) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.pluginmanager.BukkitPluginManager.load(BukkitPluginManager.java:354) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.plugins.PluginManager.load(PluginManager.java:173) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/paper.com.rylinaux.plugman.pluginmanager.PaperPluginManager.load(PaperPluginManager.java:62) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.commands.executables.ReloadCommand.reloadPlugin(ReloadCommand.java:137) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.commands.executables.ReloadCommand.execute(ReloadCommand.java:100) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.commands.PlugManCommandHandler.onCommand(PlugManCommandHandler.java:70) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/paper.com.rylinaux.plugman.commands.PaperCommandCreator$1.execute(PaperCommandCreator.java:35) ~[PlugManX-3.0.2.jar:?]
        at io.papermc.paper.command.brigadier.PaperCommands.lambda$register$2(PaperCommands.java:176) ~[paper-1.21.10.jar:?]
        at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
        at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:30) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:105) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:458) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performCommand(Commands.java:364) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performCommand(Commands.java:352) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performPrefixedCommand(Commands.java:343) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.handleConsoleInputs(DedicatedServer.java:597) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.tickConnection(DedicatedServer.java:553) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1807) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1604) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:430) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1324) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:366) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]
[12:43:43 INFO]: [Minesuiteus] loading core libraries...
[12:43:43 INFO]: [Minesuiteus] Minesuiteus is loading
[12:43:43 INFO]: [Minesuiteus] foo
java.lang.Throwable: null
        at Minesuiteus-1.0.0-1760319822338.jar/me.taucu.minesuiteus.Minesuiteus.onLoad(Minesuiteus.java:63) ~[Minesuiteus-1.0.0-1760319822338.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.pluginmanager.BukkitPluginManager.loadAndEnablePlugin(BukkitPluginManager.java:369) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.pluginmanager.BukkitPluginManager.load(BukkitPluginManager.java:354) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.plugins.PluginManager.load(PluginManager.java:173) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/paper.com.rylinaux.plugman.pluginmanager.PaperPluginManager.load(PaperPluginManager.java:62) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.commands.executables.ReloadCommand.reloadPlugin(ReloadCommand.java:137) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.commands.executables.ReloadCommand.execute(ReloadCommand.java:100) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.commands.PlugManCommandHandler.onCommand(PlugManCommandHandler.java:70) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/paper.com.rylinaux.plugman.commands.PaperCommandCreator$1.execute(PaperCommandCreator.java:35) ~[PlugManX-3.0.2.jar:?]
        at io.papermc.paper.command.brigadier.PaperCommands.lambda$register$2(PaperCommands.java:176) ~[paper-1.21.10.jar:?]
        at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
        at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:30) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:105) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:458) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performCommand(Commands.java:364) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performCommand(Commands.java:352) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performPrefixedCommand(Commands.java:343) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.handleConsoleInputs(DedicatedServer.java:597) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.tickConnection(DedicatedServer.java:553) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1807) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1604) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:430) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1324) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:366) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]
[12:43:43 ERROR]: [Minesuiteus] onLoad() called while instance was already defined? Did a plugin manager fumble the bag?
[12:43:43 ERROR]: Command exception: /plugman reload Minesuiteus
java.lang.Throwable: onLoad() called while instance was already defined? Did a plugin manager fumble the bag?
        at Minesuiteus-1.0.0-1760319822338.jar/me.taucu.minesuiteus.Minesuiteus.onLoad(Minesuiteus.java:68) ~[Minesuiteus-1.0.0-1760319822338.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.pluginmanager.BukkitPluginManager.loadAndEnablePlugin(BukkitPluginManager.java:369) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.pluginmanager.BukkitPluginManager.load(BukkitPluginManager.java:354) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.plugins.PluginManager.load(PluginManager.java:173) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/paper.com.rylinaux.plugman.pluginmanager.PaperPluginManager.load(PaperPluginManager.java:62) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.commands.executables.ReloadCommand.reloadPlugin(ReloadCommand.java:137) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/core.com.rylinaux.plugman.commands.executables.ReloadCommand.execute(ReloadCommand.java:100) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/bukkit.com.rylinaux.plugman.commands.PlugManCommandHandler.onCommand(PlugManCommandHandler.java:70) ~[PlugManX-3.0.2.jar:?]
        at PlugManX-3.0.2.jar/paper.com.rylinaux.plugman.commands.PaperCommandCreator$1.execute(PaperCommandCreator.java:35) ~[PlugManX-3.0.2.jar:?]
        at io.papermc.paper.command.brigadier.PaperCommands.lambda$register$2(PaperCommands.java:176) ~[paper-1.21.10.jar:?]
        at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
        at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:30) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:105) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:458) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performCommand(Commands.java:364) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performCommand(Commands.java:352) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.commands.Commands.performPrefixedCommand(Commands.java:343) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.handleConsoleInputs(DedicatedServer.java:597) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.tickConnection(DedicatedServer.java:553) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1807) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1604) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:430) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1324) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:366) ~[paper-1.21.10.jar:1.21.10-69-610f1d2]
        at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]
[12:43:43 INFO]: An unexpected error occurred trying to execute that command
[12:43:43 INFO]: [Minesuiteus] finished loading core libraries.

In ServerPluginProviderStorage

    // We need to call the load methods AFTER all plugins are constructed
    @Override
    public void processProvided(PluginProvider<JavaPlugin> provider, JavaPlugin provided) {
        try {
            provided.getLogger().info(String.format("Loading server plugin %s", provided.getPluginMeta().getDisplayName()));
            provided.onLoad(); <--- L:59 calls onLoad
        } catch (Throwable ex) {
            // Don't mark that provider as ERRORED, as this apparently still needs to run the onEnable logic.
            provided.getSLF4JLogger().error("Error initializing plugin '%s' in folder '%s' (Is it up to date?)".formatted(provider.getFileName(), provider.getParentSource()), ex);
        }
    }

TauCu avatar Oct 13 '25 01:10 TauCu

Ah, that sure sounds like an oversight. I'll fix this as soon as possible

Test-Account666 avatar Oct 17 '25 06:10 Test-Account666