PlugMan icon indicating copy to clipboard operation
PlugMan copied to clipboard

Properly unload plugins from all places in latest paper

Open DasBabyPixel opened this issue 1 year ago • 1 comments

Just thought I'd make this PR in case anyone is interested. Fixes some memory leaks which cause plugins to not be unloaded correctly. I have only tested this with paper 1.21.1, not older versions / other server implementations

DasBabyPixel avatar Sep 16 '24 11:09 DasBabyPixel

Thank you for this. I'll have a look and test it against some versions.

And sorry for not being very active at the moment

Test-Account666 avatar Sep 17 '24 08:09 Test-Account666

@Test-Account666 Any plan to still merge this in?

codeHusky avatar Jun 26 '25 09:06 codeHusky

I haven't forgotten about this PR, don't worry.

I plan to merge it alongside deprecating older versions.

I'd like to move on from ancient versions like 1.8

Test-Account666 avatar Jun 26 '25 09:06 Test-Account666

This PR has an incompatibility issue with Folia, this change seems to fix it though I'm unsure if the Folia code behaves the same

image

codeHusky avatar Jun 26 '25 09:06 codeHusky

Oh, yeah. Makes sense.

Thanks for the reminder about Folia

Test-Account666 avatar Jun 26 '25 09:06 Test-Account666