Vanilla-Conquer icon indicating copy to clipboard operation
Vanilla-Conquer copied to clipboard

RA draws way too many Tesla bolts

Open tomsons26 opened this issue 5 years ago • 4 comments

vanillara_5bCTDPp1wu

tomsons26 avatar Oct 23 '20 19:10 tomsons26

The TeslaZap effect is drawn in TechnoClass::Draw_It() which getsexecuted multiple times per logic frame apparently (whenever GscreenClass::Render() is called, while the TechnoClass::AI (per frame) logic is executed less than the render frame.

A quick fix would be to add an extra variable to check the last logic frame the effect was rendered on it to prevent it from rendering multiple times on the same logic frame.

The original game (3.03) had the opposite issue where it wouldn't always draw the tesla effect at all sometimes.

mvdhout1992 avatar Feb 15 '21 16:02 mvdhout1992

Can anyone confirm this is is still an issue in recent builds, msvc builds on windows 10 look fine to me, so confirmation on other platforms would be welcome as well.

OmniBlade avatar Jan 07 '22 11:01 OmniBlade

@hifi confirm if looks okay on linux perhaps?

OmniBlade avatar Jan 07 '22 11:01 OmniBlade

It currently looks like this on Linux:

https://user-images.githubusercontent.com/10992973/161741991-0d3353a2-0196-44bd-9ca9-b2bf07c8d693.mp4

Don't really have anything to compare it to though

hazelnot avatar Apr 05 '22 11:04 hazelnot