Thyme
Thyme copied to clipboard
TheAssemblyArmada
Switch all int types to int32_t
I don't see that this is necessary. On all platforms that we are ever likely to bump into (given that Thyme is never going to run on a Cray supercomputer) int and int32_t are identical in size and totally interchangeable.
int vs int32_t, uint vs uint32_t, short vs int16_t, ushort vs uint16_t, char vs int8_t, unsigned char vs uint8_t will make no difference to the code on the platforms we are ever going to run on.
We have already had situations where the wrong size is used due to long. It seems silly to have this issue when it's easily fixed by using the sized types
Can we do this in chunks? Reviewing 560 files is quite much.
Certainly can do. I wasn't sure if it was easier for a review doing all of one type at a time or all types in one folder of files at a time
Must not be submitted, if ever, before
Why?
This just resolves all of it in a oner using a find and replace it can be done at any time and takes all of a couple of seconds to do + a little bit of massaging clang format. Unless you are just saying your prs will be a bit annoying to rebase?