Thyme icon indicating copy to clipboard operation
Thyme copied to clipboard

Units stop moving in Replay playback

Open xezon opened this issue 3 years ago • 3 comments

Units stop moving in Replay playback.

Extract test replay file to \Documents\Command and Conquer Generals Zero Hour Data\Replays
12_05_22_1v1_OoEExCaL_Leader.zip

Extract test map files to Documents\Command and Conquer Generals Zero Hour Data\Maps [RANK] Snowy Drought v4.zip

Load Replay in game. Press F button to fast forward.

Notice how the produced tanks just pile in the map center. Thyme issue.

xezon avatar Jan 07 '22 21:01 xezon

Source is NameKeyGenerator Name_To_Key hooks, i can't figure out why

tomsons26 avatar Jan 07 '22 23:01 tomsons26

Lots of issues here, namekey issue is the operator used for incrementation of m_key WeaponBonusSet::Parse_Weapon_Bonus_Set_Ptr seems the next source but wouldn't seem the last INI::Load is another, something down its chain of calls it makes from the table GeometryInfo is also a source, fixed 3 so far, pr'd fixes

tomsons26 avatar Jan 09 '22 21:01 tomsons26

Just to keep this issue updated. Replay still has issues but we have addressed:

  • NameKeyGenerator issue causing incorrect vet
  • GeometryInfo issues causing some of the pathing issues

There still appears to be further issues. Possible source of issues is not using fast math and also not using x87 float instructions.

duncanspumpkin avatar Jan 15 '22 09:01 duncanspumpkin