AppImageLauncher
AppImageLauncher copied to clipboard
TheAssassin
Fix #574 - Revert "Improve compatibility of binfmt-bypass with really old Docker images"
This reverts commit c810e7070e70e735edbd4be3e8e932e4e3f1a666.
Notes:
-
CentOS 7 reached End of Life on June 30, 2024
-
Arch Linux & Manjaro unstable channel have GlibC with symbol version
2.14:U memcpy@GLIBC_2.14
Regarding new builds, I'm still working on the CI bit, making some progress there. But I suppose since this fixes some Arch issue, AIL would be built by AUR anyway.
Looks okay to me. Is there an open issue which this PR solves?
Yes, this should fix #574 which was a failed to build from source (FTBFS) issue on Arch Linux. (Downstream issue mentioned on AUR here)
It looks like the problem was caused by the patchelf script here and differing glibc symbol versions. I gave a bit more explanation here based on what I found.
The gist of it was that the problem was introduced in c810e70, which was to support some old CentOS 7 versions in docker (according to comments in the code & commit message). CentOS 7 is now EoL, so this hack can probably be removed, as it's causing these build issues on distros with newer GlibC.
The other thing that appears to have been fixed is #558 [^1]. After rebuilding the AUR package with this PR's changes, appimagelauncherd no longer segfaults and creates lots of coredumps with SystemD restarting it (and using lots of disk space for coredump files). Meanwhile, the current version of extra/appimagelauncher 2.2.0-10 does still segfault in this way, causing the coredump file buildup.
[^1]: I have been running my packaged version built from this PR since around September 15th, and haven't seen the segfault issue since then. I suspect that the patchelf hack had opened up the door to some undefined behavior due to potential for GlibC linkage / ABI issues.
Since packaging is under rework (making progress, actually), I'd like to postpone this PR for now and reconsider it when the new build system has been merged.
@FabioLolix:
Hi, this patch no longer apply and is no longer needed
Ok, great! I'll close this due to the other changes fixing the build.
P.S.: Please see FabioLolix/PKGBUILD-AUR_fix#53 to fix one last issue with the AUR package.