website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

[BUG] Broken links

Open siriak opened this issue 3 years ago • 11 comments

Description of the bug

Description Code implementation links of algorithms when opened are giving 404 errors. I observed such behavior for Bubble sort.

Actual behavior

  1. Go to https://the-algorithms.com/algorithm/bubble-sort
  2. Scroll down to Code Implementation links
  3. Click on Java

Actual behavior 4. See Github 404 page (the link is https://github.com/TheAlgorithms/Java/blob/master/Sorts/BubbleSort.java)

Expected behavior 4. Bubble sort page should open (the link is https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BubbleSort.java)

Add screenshots of the bug (if applicable)

No response

Additional information/context

Originally reported here https://github.com/TheAlgorithms/Java/issues/2840

siriak avatar Nov 24 '21 08:11 siriak

All of those links in the explanations are hardcoded into https://github.com/TheAlgorithms/Algorithms-Explanation, so they would have to be updated there.

maltejur avatar Nov 24 '21 13:11 maltejur

Anyone working on this issue?

Tejas-Teju avatar Nov 24 '21 13:11 Tejas-Teju

The wrong links in https://github.com/TheAlgorithms/Algorithms-Explanation are still there and I currently don't have the time to fix them.

maltejur avatar Nov 24 '21 13:11 maltejur

Hi, I'd like to contribute to this issue. Kindly assign to me. Thanks!

mgncodes avatar Dec 13 '21 09:12 mgncodes

Sure

maltejur avatar Dec 13 '21 16:12 maltejur

Hi @maltejur, I have a doubt. The link for code implementation is changed in the issue mentioned by @Panquesito7 , but the PR made in that issue is still not merged, so it is still not updated in Algorithms-Explanation repo. Is it like, if the links in Algorithms-Explanation repo is updated, then only the changes in the link will be reflected here? Kindly clarify.

mgncodes avatar Dec 14 '21 05:12 mgncodes

As the comment in that PR already says, the pull request only fixed two links, but every java link in that repository is broken. So it would be great to just have another PR in Algorithms-Explanation where all the links are fixed.

maltejur avatar Dec 14 '21 08:12 maltejur

@siriak @maltejur I have the code ready on my fork, raising a PR real quick.

sambhavsaxena avatar Jan 27 '22 13:01 sambhavsaxena

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 27 '22 15:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 20:07 stale[bot]

Hello I would like to contribute contribute to this issue. Kindly assign it to me please

riyaz2014 avatar Sep 19 '22 04:09 riyaz2014

Closing as this should be fixed upstream at https://github.com/TheAlgorithms/Algorithms-Explanation

Panquesito7 avatar Jan 16 '24 04:01 Panquesito7