Rust icon indicating copy to clipboard operation
Rust copied to clipboard

add multiply.rs

Open mengfansheng-git opened this issue 1 year ago • 8 comments
trafficstars

Given two non-negative integers num1 and num2 expressed as strings, returns the product of num1 and num2, which is also expressed as a string. Note: You cannot use any of the built-in BigInteger libraries or directly convert the input to an integer.

mengfansheng-git avatar May 14 '24 02:05 mengfansheng-git

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.96%. Comparing base (bba0b0d) to head (78623af).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   94.95%   94.96%           
=======================================
  Files         302      303    +1     
  Lines       22527    22563   +36     
=======================================
+ Hits        21390    21426   +36     
  Misses       1137     1137           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 14 '24 02:05 codecov-commenter

This clippy error should be a machine issue?

mengfansheng-git avatar May 16 '24 03:05 mengfansheng-git

This clippy error should be a machine issue

I think these errors are related to the recent update of the clippy. I will make a suitable fix in the evening.

vil02 avatar May 16 '24 09:05 vil02

This clippy error should be a machine issue

I think these errors are related to the recent update of the clippy. I will make a suitable fix in the evening.

ok

mengfansheng-git avatar May 16 '24 09:05 mengfansheng-git

When you will update/rebase your branch, the CI should pass.

vil02 avatar May 16 '24 16:05 vil02

multiply("03", "2")返回"06"

multiply2: ("03", "2", "06") multiply3: ("03", "02", "006") It currently returns. Do I need to add it to test?

mengfansheng-git avatar May 20 '24 08:05 mengfansheng-git

multiply("03", "2")返回"06"

multiply2: ("03", "2", "06") multiply3: ("03", "02", "006") It currently returns. Do I need to add it to test?

I would suggest to exclude inputs like "03", "003" or "X3", simply because they are not properly formatted numbers.

vil02 avatar May 20 '24 11:05 vil02

multiply("03", "2")返回"06"

multiply2: ("03", "2", "06") multiply3: ("03", "02", "006") It currently returns. Do I need to add it to test?

I would suggest to exclude inputs like "03", "003" or "X3", simply because they are not properly formatted numbers.

I'll add a string formatting judgment

mengfansheng-git avatar May 21 '24 01:05 mengfansheng-git