Rust icon indicating copy to clipboard operation
Rust copied to clipboard

Refactor Heap Sort Implementation

Open sozelfist opened this issue 1 year ago • 2 comments

Description

  • Implement generic heap sort that can sort arrays in both ascending and descending order.
  • Parametrized tests using macros
  • Add file and function docstrings.

Type of change

  • Refactor old implementations

Checklist:

  • [x] I ran the below commands using the latest version of rust nightly.
  • [x] I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • [x] I ran cargo fmt just before my last commit.
  • [x] I ran cargo test just before my last commit and all tests passed.
  • [x] I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • [x] I added my algorithm to DIRECTORY.md with the correct link.
  • [x] I checked COUNTRIBUTING.md and my code follows its guidelines.

sozelfist avatar Apr 23 '24 09:04 sozelfist

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.78%. Comparing base (1bd27f5) to head (9b73940).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
- Coverage   94.79%   94.78%   -0.01%     
==========================================
  Files         298      298              
  Lines       22177    22161      -16     
==========================================
- Hits        21022    21006      -16     
  Misses       1155     1155              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 23 '24 09:04 codecov-commenter

Can you please have a look at this PR, @vil02?

sozelfist avatar Apr 29 '24 08:04 sozelfist

Thanks! Your suggestion is more concise and definite.

sozelfist avatar May 04 '24 13:05 sozelfist