Python icon indicating copy to clipboard operation
Python copied to clipboard

feat: ✨ Implementation of Boyle's law

Open NinjaSoulPirate opened this issue 1 year ago • 6 comments

Describe your change:

Implemented Boyle's law to find the unknown value of Pressure or Volume

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

NinjaSoulPirate avatar Oct 06 '23 12:10 NinjaSoulPirate

Hi, @NinjaSoulPirate Could you please assign this pr to me

akshatvermavi avatar Oct 07 '23 07:10 akshatvermavi

Hi, @akshatvermavi I don't know how

NinjaSoulPirate avatar Oct 09 '23 04:10 NinjaSoulPirate

Hi @tianyizheng02, I have done the requested changes could you review this again and let me know if it's good enough. Thanks !!

NinjaSoulPirate avatar Oct 12 '23 09:10 NinjaSoulPirate

Hi @tianyizheng02, I have done the requested changes could you review this again and let me know if it's good enough. Thanks !!

NinjaSoulPirate avatar Oct 23 '23 11:10 NinjaSoulPirate

Hi @tianyizheng02, I have done the requested changes could you review this again and let me know if it's good enough. Thanks !!

NinjaSoulPirate avatar Oct 25 '23 05:10 NinjaSoulPirate

Hi any update ?

NinjaSoulPirate avatar Nov 22 '23 11:11 NinjaSoulPirate