Python icon indicating copy to clipboard operation
Python copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

Remove duplicate GCD implementation

Open tianyizheng02 opened this issue 2 years ago • 1 comments

Feature description

greatest_common_divisor.py and euclidean_gcd.py both have basically the same two implementations of the Euclidean algorithm for calculating the GCD of 2 numbers. Thus, one of them should probably be removed as a duplicate.

tianyizheng02 avatar Dec 30 '22 06:12 tianyizheng02

@cclauss which one we should keep

itsvinayak avatar Dec 31 '22 13:12 itsvinayak

Hey, I am Arhama . I am a beginner in open source contribution. I think I Can work on this issue. can you assign me this work.

ArhamaQ avatar Sep 25 '23 12:09 ArhamaQ

can you assign me this work.

https://github.com/TheAlgorithms/Python/pull/8871/files

My preference would be to delete the file whose name uses the gcd acronym and keep the file whose name is self-documenting (as #8078 attempted to do).

  • #8078

cclauss avatar Sep 25 '23 13:09 cclauss

Hey, is this still an issue to work on if yes can I do it

HimanshuMahto avatar Sep 26 '23 16:09 HimanshuMahto

@HimanshuMahto Read the contributing guidelines.

If you are interested in resolving an open issue, simply make a pull request with your proposed fix. We do not assign issues in this repo so please do not ask for permission to work on an issue.

tianyizheng02 avatar Sep 26 '23 20:09 tianyizheng02

Hey, I have created a PR #9108 which addresses this issue. Please review it. Thanks!

aryan1165 avatar Sep 27 '23 12:09 aryan1165