Python icon indicating copy to clipboard operation
Python copied to clipboard

clean of unnecessary checks, imports, calls

Open marksmayo opened this issue 3 years ago • 1 comments

Describe your change:

places where cleaner code is better (pylint identified) simplifying return (bools) replace type with isinstance

Checklist:

  • [X] I have read CONTRIBUTING.md.
  • [ X] This pull request is all my own work -- I have not plagiarized.
  • [ X] I know that pull requests will not be merged if they fail the automated tests.

Had issues with validate-filenames failing on pre-commit, looks like on windows it gets confused with the \ vs /, so I no-verified just that stage.

marksmayo avatar Nov 17 '22 06:11 marksmayo

Would appreciate help from reviewer - the failed test is on a file I didn't touch, and I don't believe I've modified dependencies? Looks like it's actually a problem with the runner not finding a config?

marksmayo avatar Nov 17 '22 06:11 marksmayo