Python icon indicating copy to clipboard operation
Python copied to clipboard
Published 2 weeks ago • verified publisher icon TheAlgorithms

Corrected the directory of Fractional Knapsack algorithm

Open SudhanshuSuman opened this issue 3 years ago • 6 comments

Describe your change:

  • Fractional knapsack uses a greedy approach and, hence, comes under greedy_methods and not under dynamic_programming.

  • Moved the two fractional knapsack algorithm files to greedy_methods.

  • [ ] Add an algorithm?

  • [ ] Fix a bug or typo in an existing algorithm?

  • [x] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

SudhanshuSuman avatar Oct 13 '22 06:10 SudhanshuSuman

Please can you update these changes in DIRECTORY.md

Hey, @CaedenPH I noticed in contributing guidelines that we do not require updating the DIRECTORY.md file as GitHub Actions periodically autogenerates it. However, I have updated it now. Should I revert it back?

SudhanshuSuman avatar Oct 14 '22 13:10 SudhanshuSuman

Please can you update these changes in DIRECTORY.md

Hey, @CaedenPH I noticed in contributing guidelines that we do not require updating the DIRECTORY.md file as GitHub Actions periodically autogenerates it. However, I have updated it now. Should I revert it back?

Oh, I wasn't aware that there was a Github Action for this, I would assume that means you don't need to update DIRECTORY.md, however i assume that it wont make a difference now that you have updated it

CaedenPH avatar Oct 14 '22 14:10 CaedenPH

Please can you update these changes in DIRECTORY.md

Hey, @CaedenPH I noticed in contributing guidelines that we do not require updating the DIRECTORY.md file as GitHub Actions periodically autogenerates it. However, I have updated it now. Should I revert it back?

Oh, I wasn't aware that there was a Github Action for this, I would assume that means you don't need to update DIRECTORY.md, however i assume that it wont make a difference now that you have updated it

Yes. Can you review the pull request? It seems @Kush1101 was requested but he is not active.

SudhanshuSuman avatar Oct 14 '22 15:10 SudhanshuSuman

@cclauss Can you review? Looks good to me

CaedenPH avatar Oct 15 '22 16:10 CaedenPH

There is a git conflict below? Are the algorithms being modified or just moved?

cclauss avatar Oct 15 '22 17:10 cclauss

There is a git conflict below? Are the algorithms being modified or just moved?

I have fixed the conflict, my branch was not up to date. The algorithms are just moved.

SudhanshuSuman avatar Oct 15 '22 19:10 SudhanshuSuman