Python icon indicating copy to clipboard operation
Python copied to clipboard

[Binary Tree] Different views of binary tree added

Open kondekarshubham123 opened this issue 2 years ago • 1 comments

Describe your change:

Problem: Given root of binary Tree, print the

  1. binary-tree-right-side-view
  2. binary-tree-left-side-view
  3. binary-tree-top-side-view
  4. binary-tree-bottom-side-view
  • [X] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [X] I have read CONTRIBUTING.md.
  • [X] This pull request is all my own work -- I have not plagiarized.
  • [X] I know that pull requests will not be merged if they fail the automated tests.
  • [X] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [X] All new Python files are placed inside an existing directory.
  • [X] All filenames are in all lowercase characters with no spaces or dashes.
  • [X] All functions and variable names follow Python naming conventions.
  • [X] All function parameters and return values are annotated with Python type hints.
  • [X] All functions have doctests that pass the automated testing.
  • [X] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [X] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

kondekarshubham123 avatar Oct 11 '22 00:10 kondekarshubham123

Hi @cclauss @dhruvmanila,

Can you please review this, hacktoberfest is about to end, if any updates required please let me know.

Thanks

kondekarshubham123 avatar Oct 17 '22 15:10 kondekarshubham123

Should I added doctests as per suggested by algorithms-keeper ?

kondekarshubham123 avatar Oct 17 '22 18:10 kondekarshubham123

Hello sir, can u assign me this issue. I would love to grab this opportunity.

SwaggyRajput avatar Oct 22 '22 15:10 SwaggyRajput

Please stop waiting. We do not assign issues in this repo. Instead, we review pull requests so if you see something that is worth fixing then please create a pull request to fix it. This pull request is already merged.

cclauss avatar Oct 22 '22 16:10 cclauss