Python
Python copied to clipboard
[Matrix] Max area of island problem solved DFS algorithm
Describe your change:
Maximum area of island problem added.
- [X] Add an algorithm?
- [ ] Fix a bug or typo in an existing algorithm?
- [ ] Documentation change?
Checklist:
- [X] I have read CONTRIBUTING.md.
- [X] This pull request is all my own work -- I have not plagiarized.
- [X] I know that pull requests will not be merged if they fail the automated tests.
- [X] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- [X] All new Python files are placed inside an existing directory.
- [X] All filenames are in all lowercase characters with no spaces or dashes.
- [X] All functions and variable names follow Python naming conventions.
- [X] All function parameters and return values are annotated with Python type hints.
- [X] All functions have doctests that pass the automated testing.
- [X] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
- [X] If this pull request resolves one or more open issues then the commit message contains
Fixes: #{$ISSUE_NO}
.
hi @CaedenPH, I have made changes as per suggestions
please merge this PR under hackoberfest label
Hey, your doctests failed... Please correct this. (Your PR will not be merged with failed tests)
Also, wait, huh? Mypy is complaining, I thought we didn't use that here I have never run into this before, uh...
@CaedenPH Are you sure that type specification removal was correct?
Hey, your doctests failed... Please correct this. (Your PR will not be merged with failed tests)
yes, I have corrected this
Caeden is not responding, just put the : set
back, sorry about the confusion regarding that
yes @CenTdemeern1 , I had put : set
back
Thanks
Hi @cclauss or @dhruvmanila, Please review this PR as well
Thanks
Use that max 88 characters to put comments on fewer lines. Define one matrix and use it multiple times. If you pass me the matrix, I can calculate rows and cols. Iterate thru the matrix like a Pythonista...
for row, line in enumerate(mat):
for col, item in enumerate(line):
if item == 1 and (row, col) not in seen: