Python icon indicating copy to clipboard operation
Python copied to clipboard

Binary Insertion Sort

Open syedjafer opened this issue 2 years ago • 3 comments

Describe your change:

Implementation of binary insertion sort. Binary insertion sort is a sorting algorithm similar to insertion sort, but instead of using linear search to find the position where the element should be inserted, we use binary search. Thus, we reduce the number of comparisons for inserting one element from O(N) (Time complexity in Insertion Sort) to O(log N).

  • [X] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [X] I have read CONTRIBUTING.md.
  • [X] This pull request is all my own work -- I have not plagiarized.
  • [X] I know that pull requests will not be merged if they fail the automated tests.
  • [X] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [X] All new Python files are placed inside an existing directory.
  • [X] All filenames are in all lowercase characters with no spaces or dashes.
  • [X] All functions and variable names follow Python naming conventions.
  • [X] All function parameters and return values are annotated with Python type hints.
  • [X] All functions have doctests that pass the automated testing.
  • [X] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [X] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$6537}.

syedjafer avatar Oct 02 '22 11:10 syedjafer

@syedjafer i think so you dont need to add name

yashgosa avatar Oct 02 '22 13:10 yashgosa

@syedjafer i think so you dont need to add name

Can u pls explain this ?

syedjafer avatar Oct 02 '22 14:10 syedjafer

@sofezticated-gentleman Can you please review this.

syedjafer avatar Oct 13 '22 14:10 syedjafer

Closing this PR due to inactivity. @syedjafer, like @CaedenPH said, even if we were to accept your implementation, it should be added alongside the existing implementation rather than overwriting it.

tianyizheng02 avatar Sep 04 '23 17:09 tianyizheng02