Python
Python copied to clipboard
Add binary insertion sort algorithm
Describe your change:
- [x] Add an algorithm?
- [ ] Fix a bug or typo in an existing algorithm?
- [ ] Documentation change?
Checklist:
- [x] I have read CONTRIBUTING.md.
- [x] This pull request is all my own work -- I have not plagiarized.
- [x] I know that pull requests will not be merged if they fail the automated tests.
- [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- [x] All new Python files are placed inside an existing directory.
- [x] All filenames are in all lowercase characters with no spaces or dashes.
- [x] All functions and variable names follow Python naming conventions.
- [x] All function parameters and return values are annotated with Python type hints.
- [x] All functions have doctests that pass the automated testing.
- [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
- [x] If this pull request resolves one or more open issues then the commit message contains
Fixes: #{$ISSUE_NO}.
@dhruvmanila I think I fixed the technical and conventional errors on this one. Could you take a look?
@dhruvmanila I used the existing implementation of searches/binary_search.py as you mentioned. To access the required file (which is in another folder (searches), I added the following lines:
import sys
sys.path.append("../searches")
from binary_search import bisect_left
which violates flake8's hooks for using an import after an instruction(E402) . By sequence, the test failed.
@dhruvmanila I think I fixed the issue and the docs. Could you take a look?
@dhruvmanila i think the branch is ready to be merged