Python
Python copied to clipboard
Added Calculation Of Mechanical Energy
Describe your change:
- [x] Add an algorithm?
- [ ] Fix a bug or typo in an existing algorithm?
- [ ] Documentation change?
Checklist:
- [x] I have read CONTRIBUTING.md.
- [x] This pull request is all my own work -- I have not plagiarized.
- [x] I know that pull requests will not be merged if they fail the automated tests.
- [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- [x] All new Python files are placed inside an existing directory.
- [x] All filenames are in all lowercase characters with no spaces or dashes.
- [x] All functions and variable names follow Python naming conventions.
- [x] All function parameters and return values are annotated with Python type hints.
- [x] All functions have doctests that pass the automated testing.
- [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
- [ ] If this pull request resolves one or more open issues then the commit message contains
Fixes: #{$ISSUE_NO}
.
Can You Merge?
@CaedenPH can you help me with this?
mypy --ignore-missing-imports mechanical_energy.py
mechanical_energy.py:28: error: Incompatible types in assignment (expression has type "str", variable has type "float")
mechanical_energy.py:29: error: Unsupported operand types for + ("float" and "str")
mechanical_energy.py:54: error: Incompatible types in assignment (expression has type "str", variable has type "float")
mechanical_energy.py:55: error: Unsupported operand types for + ("float" and "str")
Found 4 errors in 1 file (checked 1 source file)
@CaedenPH can you help me with this?
mypy --ignore-missing-imports mechanical_energy.py mechanical_energy.py:28: error: Incompatible types in assignment (expression has type "str", variable has type "float") mechanical_energy.py:29: error: Unsupported operand types for + ("float" and "str") mechanical_energy.py:54: error: Incompatible types in assignment (expression has type "str", variable has type "float") mechanical_energy.py:55: error: Unsupported operand types for + ("float" and "str") Found 4 errors in 1 file (checked 1 source file)
- [ ] These errors are due to certain failed return types. For example, you supposedly return
str
, however in one case (in the exception), you return-0.0
, afloat
. You need to ensure that all possible returns are the return type that you mention. Unless you typehint the return to both float and str,float | str
Thanks! It works now that I thought about it
Merge Ready?
@CaedenPH can you merge?
sorry for ping its just ...