Python icon indicating copy to clipboard operation
Python copied to clipboard
Published 4 weeks ago • verified publisher icon TheAlgorithms

fibonacci_dynamic_recursion.py

Open tiwarinitin94 opened this issue 3 years ago • 8 comments

This file contains a solution to the Fibonacci series with recursion using the memoization technique.

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [ ] I know that pull requests will not be merged if they fail the automated tests.
  • [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [ ] All functions have doctests that pass the automated testing.
  • [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

tiwarinitin94 avatar May 09 '22 16:05 tiwarinitin94

Hi! There are versions like this which is similar to yours. You may improve this version.

poyea avatar May 12 '22 03:05 poyea

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 20:06 stale[bot]

The filename has the same typo as the doc comment

Rudxain avatar Aug 13 '22 18:08 Rudxain

I cannot see why merging is blocked?

tiwarinitin94 avatar Sep 03 '22 05:09 tiwarinitin94

The filename has the same typo as the doc comment

Changed it

tiwarinitin94 avatar Sep 03 '22 05:09 tiwarinitin94

I cannot see why merging is blocked?

Don't worry, it's ok. Currently, the PR is missing a review from a code-owner, that's why it says "blocked", because of the automated system that checks PRs

Rudxain avatar Sep 03 '22 08:09 Rudxain

What is a pre-commit issue, and how can I solve it?

tiwarinitin94 avatar Sep 06 '22 13:09 tiwarinitin94

What is a pre-commit issue, and how can I solve it?

I guess it's like the preliminary checks before a commit is accepted. To solve it, you need to know what you're going to solve:

According to the "details link", the log says that the memo var is missing a type annotation, and there's some part of the file that isn't formatted according to the "Python Black style"

Rudxain avatar Sep 07 '22 02:09 Rudxain

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that have failing tests.

cclauss avatar Oct 01 '22 10:10 cclauss

Does that mean it already exists? I checked in dynamic programming folder it wasn't there

On Thu, 12 May, 2022, 9:04 am John Law, @.***> wrote:

Hi! There are versions like this https://github.com/TheAlgorithms/Python/blob/master/maths/fibonacci.py which is similar to yours. You may improve this version.

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/Python/pull/6137#issuecomment-1124496234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFUY6IPNP67DT2RWC55A6T3VJR35RANCNFSM5VO2RXUA . You are receiving this because you authored the thread.Message ID: @.***>

tiwarinitin94 avatar Oct 11 '22 08:10 tiwarinitin94