Python icon indicating copy to clipboard operation
Python copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

Feature: improve branch coverage

Open Dajamante opened this issue 2 years ago • 9 comments

Describe your change:

closes #6020 Please see issue:

  • [x] Fix a bug or typo in an existing algorithm?
  • [x] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Dajamante avatar Mar 07 '22 13:03 Dajamante

Please fix the build checks.

poyea avatar Mar 17 '22 03:03 poyea

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 04:04 stale[bot]

All checks fail?

cclauss avatar Apr 16 '22 06:04 cclauss

Nice work.

SnowdenSa avatar Apr 16 '22 09:04 SnowdenSa

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 13 '22 04:06 stale[bot]

Let's fix the tests? - this would be great to have

poyea avatar Jun 13 '22 05:06 poyea

I agree! I will not have time unfortunately :(. But there are two tests that are failing according to the report. ================ 2 failed, 1117 passed, 108 warnings in 32.80s =================

Dajamante avatar Jun 13 '22 07:06 Dajamante

Yes, but maintainers do not have the edit permission, so if you could please fix those 2 issues

poyea avatar Jun 22 '22 04:06 poyea

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 04:07 stale[bot]

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that have failing tests.

cclauss avatar Oct 01 '22 10:10 cclauss