Python icon indicating copy to clipboard operation
Python copied to clipboard

added solution for problem 108

Open losito105 opened this issue 3 years ago • 4 comments

Describe your change:

I added a solution to Project Euler Problem 108.

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

losito105 avatar Oct 15 '21 01:10 losito105

Hi, so right now it looks like I'm failing two checks, both due to the fact that I'm importing a function from sympy. Is importing functions from external libraries not allowed, or am I just doing something incorrectly? Any feedback is appreciated, thank you.

losito105 avatar Oct 15 '21 17:10 losito105

==================================== ERRORS ====================================
______________ ERROR collecting project_euler/problem_108/sol1.py ______________
project_euler/problem_108/sol1.py:28: in <module>
    from sympy import Eq, S
E   ModuleNotFoundError: No module named 'sympy'

cclauss avatar Oct 15 '21 22:10 cclauss

@dhruvmanila Your review, please.

cclauss avatar Oct 15 '21 22:10 cclauss

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 03 '22 02:05 stale[bot]

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that do not have passing tests.

cclauss avatar Oct 01 '22 10:10 cclauss