Python icon indicating copy to clipboard operation
Python copied to clipboard

Reduced Time Complexity

Open abhijitgawai opened this issue 3 years ago • 5 comments

Describe your change:

Brought Time Complexity of O( max( len(first_str) , len(second_str) ) ) to O( min ( len(first_str) , len(second_str) ) )

1st :- Added Base Condition to Reduce Time Complexity

2nd :- Previously Time Complexity was O( max( len(first_str) , len(second_str) ) ) So, now on line 26, I am considering minimum length of both string. Select alternate characters of both strings. For max( len(first_str) , len(second_str) ) times and exit for loop Then Concatenate remaining characters of larger string. <- This does not require for loop, Thus reducing Time Complexity.

Now Time Complexity is O( min ( len(first_str) , len(second_str) ) )

  • [ ] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

abhijitgawai avatar Oct 12 '21 14:10 abhijitgawai

Why pre-commit is failing. What should I do to remove this error. Please Help.

abhijitgawai avatar Oct 14 '21 11:10 abhijitgawai

@abhijitgawai black linter fails because your code does not abide by the style. Open the logs and see which changes you should do. Or run black locally on your computer.

andrei-polukhin avatar Nov 27 '21 18:11 andrei-polukhin

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 03:04 stale[bot]

@pandrey2003 how do i resolve it

abhijitgawai avatar Jun 01 '22 07:06 abhijitgawai

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 09:07 stale[bot]

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that do not have passing tests.

cclauss avatar Oct 01 '22 11:10 cclauss