Python icon indicating copy to clipboard operation
Python copied to clipboard

Added an algorithm to find the max area under a histogram

Open shreayan98c opened this issue 3 years ago • 4 comments

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

shreayan98c avatar Oct 10 '21 18:10 shreayan98c

Fixed the aforementioned black convention issues

shreayan98c avatar Oct 11 '21 17:10 shreayan98c

Fixed the aforementioned psf/black/pyflakes convention issues.

shreayan98c avatar Oct 12 '21 06:10 shreayan98c

@cclauss Request you to review the changes now that all the automated tests and the checks are passing.

shreayan98c avatar Oct 14 '21 05:10 shreayan98c

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 22:07 stale[bot]