Python icon indicating copy to clipboard operation
Python copied to clipboard

Fixed: #12233

Open vedprakash226 opened this issue 1 year ago • 3 comments

I have added a logic that restricts the evaluation of log function if y_true is 0.

  • [x] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #12233

vedprakash226 avatar Oct 23 '24 13:10 vedprakash226

  • Note that y_true is an array so comparing it to 0 might not be a good idea here, and there are nonzero entries that should be calculated instead of just returning 0.
  • I think this is a duplicate of #12237

kevin1kevin1k avatar Oct 23 '24 14:10 kevin1kevin1k

@anandfresh I do not think the PR should be approved as it is not correct and do not resolve what the issue intends.

kevin1kevin1k avatar Oct 27 '24 05:10 kevin1kevin1k

@anandfresh I do not think the PR should be approved as it is not correct and do not resolve what the issue intends.

@kevin1kevin1k - Yes, my bad ! I didn't see it is an array variable . Ideally he has to check if the array length is greater than 0

anandfresh avatar Oct 27 '24 16:10 anandfresh

Closing tests_are_failing PRs to prepare for Hacktoberfest

cclauss avatar Nov 01 '24 08:11 cclauss