Python icon indicating copy to clipboard operation
Python copied to clipboard

Fix issue #11308 Haversine Distance Calculation to Use Raw Latitudes

Open Maanit491 opened this issue 1 year ago • 2 comments

Describe your change:

  • [x] Fix a bug or typo in an existing algorithm?

This pull request fixes the Haversine distance calculation in the haversine_distance.py file. The implementation previously used reduced latitudes, which can introduce inaccuracies. This change utilizes raw latitudes directly, ensuring that the calculation aligns with standard practices for spherical distance measurement.

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #11308 ".

Maanit491 avatar Oct 01 '24 20:10 Maanit491

I have resolved the bug. Please review my PR.

Maanit491 avatar Oct 01 '24 22:10 Maanit491

Kindly review my code @cclauss

Maanit491 avatar Oct 09 '24 12:10 Maanit491