Python icon indicating copy to clipboard operation
Python copied to clipboard

added two pointer directory and added solution to is_palindrome.py

Open Daanish-Hindustani opened this issue 1 year ago • 3 comments

Describe your change:

As per issue

  • [X] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • [ ] Documentation change?

Checklist:

  • [X] I have read CONTRIBUTING.md.
  • [X] This pull request is all my own work -- I have not plagiarized.
  • [X] I know that pull requests will not be merged if they fail the automated tests.
  • [X] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [X] All filenames are in all lowercase characters with no spaces or dashes.
  • [X] All functions and variable names follow Python naming conventions.
  • [X] All function parameters and return values are annotated with Python type hints.
  • [X] All functions have doctests that pass the automated testing.
  • [X] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Daanish-Hindustani avatar Sep 14 '24 16:09 Daanish-Hindustani

Looks good

Do you know how I can merge to main, since you approved the changes .

Daanish-Hindustani avatar Sep 15 '24 02:09 Daanish-Hindustani

Looks good

Do you know how I can merge to main, since you approved the changes.

Wait for [at]Claus he'll be reviewing this from his end.

imSanko avatar Sep 15 '24 09:09 imSanko

Looks good

Do you know how I can merge to main, since you approved the changes.

Wait for [at]Claus he'll be reviewing this from his end.

Do you know when these changes are being reviewed, because its been close to a week or two

Daanish-Hindustani avatar Sep 21 '24 15:09 Daanish-Hindustani