Python icon indicating copy to clipboard operation
Python copied to clipboard

Create longest_word_in_sentence.py

Open its-100rabh opened this issue 1 year ago • 4 comments

Describe your change:

A program to find the longest word in a sentence.

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [ ] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

its-100rabh avatar Jul 05 '24 05:07 its-100rabh

If I add some new test cases, there is some issue with the ruff test. The ruff/ruff (pull_request) fails for some error in the graphs directory that I have not event touched.

The failure result is: Run ruff check --output-format=github . ruff check --output-format=github . shell: /usr/bin/bash -e {0} Error: graphs/multi_heuristic_astar.py:82:12: NPY201 np.chararray will be removed in NumPy 2.0. Use numpy.char.chararray instead. Error: Process completed with exit code 1.

its-100rabh avatar Jul 07 '24 04:07 its-100rabh

Sounds good and clean.

Ah... Any issue that is stopping this from getting merged?

its-100rabh avatar Aug 07 '24 13:08 its-100rabh

Sounds good and clean.

Ah... Any issue that is stopping this from getting merged?

Connect with [at]cclauss for getting this merged or might review it for a better.

imSanko avatar Aug 07 '24 17:08 imSanko

@cclauss Can this be merged and closed?

its-100rabh avatar Oct 28 '24 07:10 its-100rabh