Python icon indicating copy to clipboard operation
Python copied to clipboard

Global variable should not using in class method

Open icecraft opened this issue 1 year ago • 3 comments

Repository commit

9caf4784aada17dc75348f77cc8c356df503c0f3

Python version (python --version)

python3.11

Dependencies version (pip freeze)

#nop

Expected behavior

Hi, guys. I come across one global variable that used in class method. I think using instance attribute would be better !

    def show_data(self):
        show_list = []
        for i in range(1, N + 1):  ==> should using self.N instead of N !
            show_list += [self.query(i, i)]
        print(show_list)

source

Actual behavior

    def show_data(self):
        show_list = []
        for i in range(1, self.N + 1):  
            show_list += [self.query(i, i)]
        print(show_list)

icecraft avatar Jan 10 '24 11:01 icecraft

Hi, i am beginner to open source can you give the instructions to solve this problem.. can i work on this issue

GantedaAravind avatar Feb 11 '24 17:02 GantedaAravind

hi i am beginner to open source too

zakariatahiri avatar Feb 21 '24 21:02 zakariatahiri

Hello! Can I get the go ahead to start on fixing this issue?

smruthi-sumanth avatar Feb 22 '24 16:02 smruthi-sumanth