JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

feat: add new Josephus file in Recursive directory

Open Lonercode opened this issue 1 year ago • 2 comments

Open in Gitpod know more

Describe your change:

As part of my contribution to hacktoberfest 2024, I have added a file recursively implementing the Josephus algorithm and its associated test to the Recursive directory. The Josephus algorithm is a counting-out game that returns the last number after removing every kth number in a circle. More on it can be found here

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Lonercode avatar Oct 10 '24 15:10 Lonercode

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.78%. Comparing base (ff314a2) to head (483f181).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
+ Coverage   84.76%   84.78%   +0.01%     
==========================================
  Files         378      379       +1     
  Lines       19742    19767      +25     
  Branches     2955     2961       +6     
==========================================
+ Hits        16735    16760      +25     
  Misses       3007     3007              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 10 '24 15:10 codecov-commenter

Thanks for the review @appgurueu Alright. In that case would there be a need to modify it for the recursive directory.

Lonercode avatar Oct 10 '24 19:10 Lonercode