JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

test: add mixed number types for LocalMaximomPoint tests

Open taekim-dev opened this issue 1 year ago • 1 comments

Open in Gitpod know more

Describe your change:

  • [ ] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

taekim-dev avatar Jun 09 '24 06:06 taekim-dev

@appgurueu Thank you for your feedback. Based on your insights, I have adjusted the test cases to align with the behavior of the existing algorithm.

I recognize the limitation of the original algorithm in not always returning the first local maximum. Your feedback on further improvements is welcomed.

taekim-dev avatar Jun 10 '24 08:06 taekim-dev