JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Compression: Huffman Coding

Open aladin002dz opened this issue 2 years ago • 2 comments

Open in Gitpod know more

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

aladin002dz avatar Oct 11 '23 15:10 aladin002dz

Why have you duplicated the code? I think there should only be a heap-based implementation; it is strictly better (more efficient) than the array-based one and of similar code complexity. In progress to remove duplicates.

aladin002dz avatar Oct 29 '23 10:10 aladin002dz

Adding the hacktoberfest-accepted label since we're close to the end of October, and this PR is pretty close to being accepted and merged later on.

appgurueu avatar Oct 29 '23 11:10 appgurueu