JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

feat: Added speed unit conversion functionality

Open Hyraze opened this issue 1 year ago • 1 comments

Open in Gitpod know more

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Hyraze avatar Oct 05 '23 18:10 Hyraze

We already have https://github.com/TheAlgorithms/JavaScript/blob/master/Conversions/LengthConversion.js, and I don't really see what this adds in contrast. If anything, you should generalize the "conversion" to take the unit table as a parameter, such that both speed and length conversions would be using the same code.

(Speed units actually consist of two units, though: a length unit divided by a time unit, and the code should ideally reflect that).

Got it. Will be sending the unit type as a parameter in the new common conversion.js Thank you.

Hyraze avatar Oct 08 '23 18:10 Hyraze