JavaScript
JavaScript copied to clipboard
tests: only test changed packages
Relates to #1193
However, having this long-running tests clogs up everyone's workflow and not "just" the CI, therefore I recommend to not just uncommenting the test but rather explicitly skipping it. This way, it's still visible in the console. Finding a solution to the runtime behavior is step 2 - but meanwhile, everyone else can continue working without that delay.
What do you think?
We'll have to leave the issue open to find a proper fix eventually however.
Yup! 👍 I mereley mentioned the issue no. in the commit message but didn't close it.
Ideally, we would want to run the tests in the changed directories only.
Jest has an onlyChanged
option that I've set up in the pre-commit hook. If that's what you like, we could also switch to that behavior for the CI, as well.
That could be great!
@raklaptudirm I've updated the CI config, as well 👍
The pr looks fine, but I had an idea. I think we would want to run all the tests in the master branch, but run tests on only the changed files in the prs. What do you all think?
I guess I could set that up with GitHub Actions, yeah. But as long as #1193 is not solved, the master
build will take forever to complete.
I've updated the Workflow accordingly - please take a look 😀
I guess I could set that up with GitHub Actions, yeah. But as long as #1193 is not solved, the
master
build will take forever to complete.
The master build should not be an issue as no one will need to wait for that to complete.