JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

:bug: Fix Validate URL algorithm

Open chetanppatil opened this issue 3 years ago • 1 comments

Open in Gitpod know more

Describe your change:

  • [ ] Add an algorithm?
  • [X] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [X] I have read CONTRIBUTING.md.
  • [X] This pull request is all my own work -- I have not plagiarized.
  • [X] I know that pull requests will not be merged if they fail the automated tests.
  • [X] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [X] All new JavaScript files are placed inside an existing directory.
  • [X] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [X] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [X] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

chetanppatil avatar Oct 13 '22 23:10 chetanppatil

This may fix the issue at hand, but it still doesn't entirely fix the algorithm (regex). Properly validating URLs is much harder than this; see Wikipedia.

Honestly I'd almost prefer getting rid of the algo entirely, because there's not much to be learned from a monster regex…

Got your point. I will look for a more proper solution then. I thought we do not want to change regex, but sure let me work on better way.

chetanppatil avatar Oct 14 '22 07:10 chetanppatil

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 02 '22 01:11 stale[bot]