JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Wrapping the example matrix with outer array

Open tmkasun opened this issue 2 years ago • 1 comments

Describe your change:

Without the outer array , given arrays are passed as 4 arguments to the island function

  • [ ] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ] All new JavaScript files are placed inside an existing directory.
  • [ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

tmkasun avatar Jul 14 '22 04:07 tmkasun

Hi @raklaptudirm & @appgurueu ,

I have added a test file for NumberOfIslands algorithm, Please review and merge.

tmkasun avatar Jul 19 '22 04:07 tmkasun

@appgurueu Kind reminder on this

tmkasun avatar Aug 01 '22 11:08 tmkasun

(the test case names are pretty redundant though)

Yes true, But if I merge them together then it becomes a bit cluttered.

@raklaptudirm Can you please review and merge

tmkasun avatar Aug 01 '22 15:08 tmkasun