Java icon indicating copy to clipboard operation
Java copied to clipboard

Add cipher class, cipher tests, enhance docs in 'AtbashCipher.java'

Open varnan6 opened this issue 1 year ago • 1 comments

  • [✅] I have read CONTRIBUTING.md.
  • [✅] This pull request is all my own work -- I have not plagiarized it.
  • [✅] All filenames are in PascalCase.
  • [✅] All functions and variable names follow Java naming conventions.
  • [✅] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [✅] All new code is formatted with clang-format -i --style=file path/to/your/file.java

varnan6 avatar Oct 10 '24 02:10 varnan6

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.95%. Comparing base (2040df8) to head (36fdaf8).

Files with missing lines Patch % Lines
...n/java/com/thealgorithms/ciphers/AtbashCipher.java 77.77% 2 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5690      +/-   ##
============================================
+ Coverage     62.90%   62.95%   +0.04%     
- Complexity     4032     4044      +12     
============================================
  Files           566      567       +1     
  Lines         16012    16030      +18     
  Branches       3081     3084       +3     
============================================
+ Hits          10073    10091      +18     
  Misses         5524     5524              
  Partials        415      415              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 10 '24 02:10 codecov-commenter

Please update with the latest master branch

siriak avatar Oct 11 '24 05:10 siriak

Looks good, thanks!

Thank you!

varnan6 avatar Oct 11 '24 06:10 varnan6

Please update with the latest master branch

Done, do check

varnan6 avatar Oct 11 '24 06:10 varnan6