Java icon indicating copy to clipboard operation
Java copied to clipboard

feat: Two new algos 👍 `TowerofHanoi.java` and `GenerateUniqueSubset.java` added

Open Tuhinm2002 opened this issue 1 year ago • 3 comments

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

Tuhinm2002 avatar Oct 03 '24 12:10 Tuhinm2002

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.03%. Comparing base (87871ef) to head (52715aa).

Files with missing lines Patch % Lines
...thealgorithms/Recursion/GenerateUniqueSubsets.java 86.66% 2 Missing :warning:
...java/com/thealgorithms/Recursion/TowerOfHanoi.java 83.33% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5546      +/-   ##
============================================
+ Coverage     53.96%   54.03%   +0.06%     
- Complexity     3387     3394       +7     
============================================
  Files           535      537       +2     
  Lines         15429    15456      +27     
  Branches       2942     2942              
============================================
+ Hits           8327     8352      +25     
- Misses         6749     6752       +3     
+ Partials        353      352       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 03 '24 12:10 codecov-commenter

@siriak I have added few more important questions in the package. Few things I left because it was already covered either in backtracking or dynamic programming, so skipped them. The rest you can review it

Tuhinm2002 avatar Oct 03 '24 12:10 Tuhinm2002

@alxkm Check I have added few missing popular algorithms of recursion.

Tuhinm2002 avatar Oct 04 '24 15:10 Tuhinm2002

@vil02 can you review the PR please

Tuhinm2002 avatar Oct 05 '24 07:10 Tuhinm2002