Java icon indicating copy to clipboard operation
Java copied to clipboard

Adaptive Replacement Cache (ARC)

Open devxadarsh opened this issue 1 year ago • 6 comments

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

devxadarsh avatar Apr 23 '24 05:04 devxadarsh

Have you read the CONTRIBUTING.md correctly? It would help if you wrote parametrized tests in a separate file in the test directory. You can refer to current implementations in this repository to know how to write tests.

sozelfist avatar Apr 23 '24 15:04 sozelfist

Codecov Report

Attention: Patch coverage is 62.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 38.65%. Comparing base (1607421) to head (5b68052).

Files Patch % Lines
.../thealgorithms/datastructures/caches/ARCCache.java 62.00% 16 Missing and 3 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5116      +/-   ##
============================================
+ Coverage     38.56%   38.65%   +0.08%     
- Complexity     2378     2388      +10     
============================================
  Files           516      517       +1     
  Lines         15313    15363      +50     
  Branches       2957     2963       +6     
============================================
+ Hits           5906     5938      +32     
- Misses         9121     9137      +16     
- Partials        286      288       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 23 '24 19:04 codecov-commenter

Please ensure that tests are added to handle lines with partial coverage.

sozelfist avatar Apr 24 '24 02:04 sozelfist

You should format the code. LGTM

sozelfist avatar Apr 24 '24 13:04 sozelfist

Please format your code using clang-format.

sozelfist avatar May 02 '24 01:05 sozelfist

Please add the missing tests and update your branch.

vil02 avatar May 09 '24 18:05 vil02

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

github-actions[bot] avatar Jun 25 '24 00:06 github-actions[bot]

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

github-actions[bot] avatar Jul 02 '24 00:07 github-actions[bot]