Java icon indicating copy to clipboard operation
Java copied to clipboard

[FEATURE REQUEST] Vernam Cipher

Open amansheoran15 opened this issue 2 years ago • 9 comments

What would you like to Propose?

I'd like to implement vernam cipher for cipher folder.

Issue details

Currently vernam cipher is missing in ciphers folder, I'd like to implement it.

Additional Information

No response

amansheoran15 avatar Oct 01 '23 06:10 amansheoran15

Hey there I would like to contribute to this project, please assign me this issue

krupalitandel1 avatar Oct 03 '23 11:10 krupalitandel1

I want to work on this issue

Rohxn16 avatar Oct 08 '23 10:10 Rohxn16

@amansheoran15 are you working on this? I could not find your PR. If not, please inform us. It seems that @krupalitandel1 and @Rohxn16 want do do it.

vil02 avatar Oct 22 '23 11:10 vil02

I was waiting for approval to do this , I'll do this

amansheoran15 avatar Oct 22 '23 11:10 amansheoran15

I was waiting for approval to do this , I'll do this

@amansheoran15 great! When you will be ready, please mention me in the PR. Please make sure to add tests of your implementation (and do not add the main method to your class). Some good PR to look at:

  • #4456,
  • #4465.

vil02 avatar Oct 22 '23 11:10 vil02

I'm not able to run the code , it says to upgrade version to 17 , I use Java SDK 16. Also how to test code without main ? I'm confused

amansheoran15 avatar Oct 22 '23 11:10 amansheoran15

I guess you will add tests for your class like VernamCipherTest.java. You can type in the console (in the root of this project) something like

mvn test

or

mvn test -Dtest=VernamCipherTest

just to test your implementation.

If you have problems with creating a local environment, you can always use gitpod - this repo is setup to work there.

vil02 avatar Oct 22 '23 11:10 vil02

I wanna work on this is one, is it available now?

Rohxn16 avatar Oct 22 '23 12:10 Rohxn16

I wanna work on this is one, is it available now?

I think @amansheoran15 is working on it.

vil02 avatar Oct 22 '23 14:10 vil02

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

github-actions[bot] avatar Feb 15 '24 00:02 github-actions[bot]

Please reopen this issue once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

github-actions[bot] avatar Feb 22 '24 00:02 github-actions[bot]