C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

doc, fix: typo in merge sort and use vector instead of raw array

Open pipinstallaadit opened this issue 1 year ago • 0 comments

  1. Typographical Error in Doxygen Comment

In the Doxygen comment at the beginning of the file, "Merege Sort" should be corrected to "Merge Sort".

  1. Merging Logic

In the merge function, the merging logic can lead to out-of-bounds access if both sub-arrays have been completely traversed. The condition in the while loop should ensure that you only access elements of L and R if they are within bounds:

  1. Memory Management

Using new and delete[] for the temporary arrays (L and R) is fine, but you can also use std::vector from the C++ Standard Library to simplify memory management:

  1. Input Validation

You should consider adding input validation when reading the number of elements and the actual elements to avoid undefined behavior.

  1. Main Function Improvements

You can also enhance the main function by encapsulating the input logic in a separate function, improving readability.

Description of Change

Checklist

  • [ x] Added description of change
  • [ x] Added file name matches File name guidelines
  • [ x] Added tests and example, test must pass
  • [ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • [x] Relevant documentation/comments is changed or added
  • [ ] PR title follows semantic commit guidelines
  • [ ] Search previous suggestions before making a new one, as yours may be a duplicate.
  • [ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

pipinstallaadit avatar Oct 15 '24 08:10 pipinstallaadit