C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

Implementation of Non-preemptive SJF scheduling

Open LakshmiSrikumar opened this issue 1 year ago • 5 comments

Description of Change

Non pre-emptive SJF Scheduling algorithm Added C++ implementation of SJF scheduling algorithm in the directory cpu_scheduling/

Checklist

  • [x] Added description of change
  • [x] Added file name matches File name guidelines
  • [x] Added tests and example, test must pass
  • [x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • [x] Relevant documentation/comments is changed or added
  • [x] PR title follows semantic commit guidelines
  • [x] Search previous suggestions before making a new one, as yours may be a duplicate.
  • [x] I acknowledge that all my contributions will be made under the project's license.

Notes:

LakshmiSrikumar avatar Oct 09 '24 13:10 LakshmiSrikumar

  1. put it in some directory instead of the root directory.
  2. you haven't checked any of the checkboxes in your pull request
  3. please add a description to the pr

realstealthninja avatar Oct 09 '24 13:10 realstealthninja

https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#Commit-Guidelines read this contributing file thank you!

realstealthninja avatar Oct 09 '24 13:10 realstealthninja

@realstealthninja I have done the following

LakshmiSrikumar avatar Oct 09 '24 13:10 LakshmiSrikumar

@realstealthninja Could you please review the PR ? And could the hacktober label be put ?

LakshmiSrikumar avatar Oct 10 '24 07:10 LakshmiSrikumar

I have done the necessary changes.

  1. changed the file directory to /cpu_scheduling_algorithms
  2. Now, the test function will generate 10 different testcases in which it will print the before and after the SJF scheduling for each test case.

@realstealthninja Kindly review the PR and please accept it.

LakshmiSrikumar avatar Oct 12 '24 05:10 LakshmiSrikumar

@realstealthninja could you please approve the repo ?

LakshmiSrikumar avatar Oct 16 '24 10:10 LakshmiSrikumar

The approved label is not added

LakshmiSrikumar avatar Oct 17 '24 17:10 LakshmiSrikumar

the approved label is not added and the hacktober has not accepted the repo. Could you tell why ?

On Thu, Oct 17, 2024 at 9:07 PM realstealthninja @.***> wrote:

@.**** approved this pull request.

Lgtm!

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/C-Plus-Plus/pull/2801#pullrequestreview-2375614731, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBVMSXJBSFNZY5AOPNB33ZTZ37KTDAVCNFSM6AAAAABPUQSYHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVGYYTINZTGE . You are receiving this because you modified the open/close state.Message ID: @.***>

LakshmiSrikumar avatar Oct 17 '24 18:10 LakshmiSrikumar

the approved label is not added and the hacktober has not accepted the repo. Could you tell why ? … On Thu, Oct 17, 2024 at 9:07 PM realstealthninja @.> wrote: @.* approved this pull request. Lgtm! — Reply to this email directly, view it on GitHub <#2801 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBVMSXJBSFNZY5AOPNB33ZTZ37KTDAVCNFSM6AAAAABPUQSYHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVGYYTINZTGE . You are receiving this because you modified the open/close state.Message ID: @.***>

I'm very sorry. I've added it now! :heart: thanks again for contributing

realstealthninja avatar Oct 19 '24 09:10 realstealthninja