C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

Create Unbounded_knapsack.cpp

Open yeolesanskruti opened this issue 1 year ago • 9 comments

Description of Change

Issue - #2782

Added Unbounded Knapsack Algorithm in Dp section with algorithm, task and test cases. Also code is verified using gfg ide.

For reference :

Screenshot 2024-10-07 213621

Checklist

  • [x] Added description of change
  • [x] Added file name matches File name guidelines
  • [x] Added tests and example, test must pass
  • [x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • [x] Relevant documentation/comments is changed or added
  • [x] PR title follows semantic commit guidelines
  • [x] Search previous suggestions before making a new one, as yours may be a duplicate.
  • [x] I acknowledge that all my contributions will be made under the project's license.

Notes: Please review and suggest changes if any @realstealthninja

yeolesanskruti avatar Oct 07 '24 16:10 yeolesanskruti

Sure @realstealthninja I would update the PR soon. Thank you.

yeolesanskruti avatar Oct 08 '24 13:10 yeolesanskruti

I have updated the documentation and code accordingly. Please review @realstealthninja . Thank you.

yeolesanskruti avatar Oct 08 '24 13:10 yeolesanskruti

@realstealthninja I have updated accordingly. Please review.

yeolesanskruti avatar Oct 08 '24 17:10 yeolesanskruti

@realstealthninja I have updated the file accordingly. Please review.

yeolesanskruti avatar Oct 09 '24 16:10 yeolesanskruti

@realstealthninja done all changes accordingly.

yeolesanskruti avatar Oct 10 '24 15:10 yeolesanskruti

@realstealthninja all changes are done accordingly. Hope so code is ready for merge

yeolesanskruti avatar Oct 11 '24 17:10 yeolesanskruti

@realstealthninja done. Hope that file is ready for the merge now.

yeolesanskruti avatar Oct 13 '24 06:10 yeolesanskruti

@realstealthninja No, in the standard unbounded knapsack problem, the maximum value cannot be negative. The problem is designed to maximize the total value of items placed in the knapsack, and item values are typically non-negative. If all items have zero or negative values, the optimal solution would be to select no items, resulting in a maximum value of 0. Thus, the maximum value is always non-negative.

yeolesanskruti avatar Oct 13 '24 16:10 yeolesanskruti

@realstealthninja No, in the standard unbounded knapsack problem, the maximum value cannot be negative. The problem is designed to maximize the total value of items placed in the knapsack, and item values are typically non-negative. If all items have zero or negative values, the optimal solution would be to select no items, resulting in a maximum value of 0. Thus, the maximum value is always non-negative.

oh i see! thanks for the clarification

realstealthninja avatar Oct 14 '24 13:10 realstealthninja

Allow me to work on this , I am kinda late to hacktober so want to complete my PRs

Pranjal-231003 avatar Oct 23 '24 11:10 Pranjal-231003