C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

[BUG] gcc >= 13 reordered headers.

Open realstealthninja opened this issue 1 year ago • 5 comments

Description

#2702 mentions reports of algorithms failing to compile due to a reordering of the headerfiles. Including cstdint would be better practice too.

Expected behavior

all typedefs of primitive types containing files compiles

Actual behavior

Compilation failure

Steps to reproduce

  1. Use gcc >= 13
  2. Run cmake build on any of the algorithm containing typedefs like uint8_t

Context

Requiring temporary inclusions of cstdint before creating changes then removing them for the actual pr

Additional information

No response

realstealthninja avatar Aug 21 '24 01:08 realstealthninja

dockcross/dockcross#832 is another example of users being affected

realstealthninja avatar Aug 21 '24 01:08 realstealthninja

Merged #2702 If you find more examples please raise a pull request

realstealthninja avatar Aug 31 '24 01:08 realstealthninja

81 files are affected. currently going to each and every file and manually adding headers.

realstealthninja avatar Aug 31 '24 05:08 realstealthninja

@VirtualTim happy to report we have pr that will fix the gcc reordering issue

realstealthninja avatar Aug 31 '24 06:08 realstealthninja

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 02 '24 00:10 github-actions[bot]