C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

Rework on Stack Array Data Structure

Open sozelfist opened this issue 1 year ago • 5 comments

What I have done in this PR:

  • Reorganize code in data_structure namespace and Stack class
  • The destructor is added to the Stack class to ensure memory deallocation
  • Comments are added to the member functions to describe their purpose
  • The self-test function is provided, which demonstrates the usage of the Stack class and its methods.

Description of Change

Checklist

  • [x] Added description of change
  • [x] Added file name matches File name guidelines
  • [x] Added tests and example, test must pass
  • [x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • [x] Relevant documentation/comments is changed or added
  • [x] PR title follows semantic commit guidelines
  • [x] Search previous suggestions before making a new one, as yours may be a duplicate.
  • [x] I acknowledge that all my contributions will be made under the project's license.

Notes:

sozelfist avatar Mar 18 '24 02:03 sozelfist

Please take a look on this PR @realstealthninja, @Panquesito7

sozelfist avatar Mar 19 '24 01:03 sozelfist

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 19 '24 00:04 github-actions[bot]

Could you have a look on this PR @realstealthninja

sozelfist avatar Apr 19 '24 00:04 sozelfist

Can you add don't-close label for this PR, @mrmagic2020?

sozelfist avatar Apr 30 '24 12:04 sozelfist

Can you add don't-close label for this PR, @mrmagic2020?

Sorry, I don't have write access to this repo... you still need to wait for the maintainers

mrmagic2020 avatar Apr 30 '24 22:04 mrmagic2020

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 25 '24 00:08 github-actions[bot]

Thanks, @realstealthninja. Can you have a look?

sozelfist avatar Aug 31 '24 02:08 sozelfist

Thanks for the quick fixes.

sozelfist avatar Aug 31 '24 02:08 sozelfist

@TruongNhanNguyen could you delete the stack.hpp file from that directory as well? thanks.

realstealthninja avatar Aug 31 '24 02:08 realstealthninja

On second thought revert that, we can do that in another pr. Sorry for the confusion. The stack.hpp problem seems out of the scope of this pr

realstealthninja avatar Aug 31 '24 03:08 realstealthninja

Thanks for kindly reviews, and quick responses. This PR existed for a long time, so I am delighted to see it merged.

sozelfist avatar Aug 31 '24 04:08 sozelfist

Merging this! thanks for your contribution :heart:

realstealthninja avatar Sep 01 '24 04:09 realstealthninja